Repository navigation
Document undocumented SDK behaviour in the README - #60
Open
jrosendahl-opt wants to merge 3 commits into
Open
jrosendahl-opt wants to merge 3 commits into
jrosendahl-opt wants to merge 3 commits into
Conversation
- Listeners are called on the main thread (except tryIdentifyFromUrl's immediate error when no valid oeid is found). - How the Google Advertising ID is read and attached, the 3 second wait, Limit Ad Tracking, that consent is the app's responsibility via skipAdvertisingIdDetection, and how to remove the merged AD_ID permission. - Every OptableIdentifier's prefix and encoding, Hem/HashedPhoneNumber validation, and not passing hashed values to Email/PhoneNumber. - The fields of OptableTargeting, and that profile returns one. The Google Advertising ID text describes behaviour after the per-instance GAID state and 3 second timeout fixes, so this should merge after them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
Match #62: every identify and targeting call reads the GAID (never cached), waiting up to advertisingIdTimeoutMs (100 ms by default), and skipAdvertisingIdDetection can be changed at any time, applying from the next call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
Match #62: advertisingIdTimeoutMs is at least 1 ms, so zero no longer means the GAID is not added, and reading the GAID typically takes tens of milliseconds depending on the device. skipAdvertisingIdDetection is the way to never add it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README didn't document several things integrators need to know: which thread listeners run on, how the Google Advertising ID is read and sent (and that consent is the app's job), how each
OptableIdentifieris encoded, and what atargetingorprofileresult contains.